netdev - 回复: [PATCH net v2] net: thunderx: Fix resource leaks in a device_for_each_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 6 Jul 2023 03:34:29 +0000
From: 王明-软件底层技术部 <machel@...o.com>
To: Markus Elfring <Markus.Elfring@....de>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Sunil Goutham
	<sgoutham@...vell.com>, opensource.kernel <opensource.kernel@...o.com>, LKML
	<linux-kernel@...r.kernel.org>
Subject:
 回复: [PATCH net v2] net: thunderx: Fix resource leaks in a device_for_each_child_node() loop

Hi Markus.
Can you help me make a template to improve the wording? I have little experience in this area. Thank you😊
Regards,
Wang.
-----邮件原件-----
发件人: Markus Elfring <Markus.Elfring@....de> 
发送时间: 2023年7月6日 3:33
收件人: 王明-软件底层技术部 <machel@...o.com>; netdev@...r.kernel.org; kernel-janitors@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Sunil Goutham <sgoutham@...vell.com>
抄送: opensource.kernel <opensource.kernel@...o.com>; LKML <linux-kernel@...r.kernel.org>
主题: Re: [PATCH net v2] net: thunderx: Fix resource leaks in a device_for_each_child_node() loop

> The device_for_each_child_node() loop in
> bgx_init_of_phy() function should have
> wnode_handle_put() before break
> which could avoid resource leaks.
> This patch could fix this bug.

Please choose a better imperative change suggestion.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94


How do you think about to add the tag “Fixes”?

Regards,
Markus