netdev - Re: [PATCH net] gve: Set default duplex configuration to full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230706080301.GU6455@unreal>
Date: Thu, 6 Jul 2023 11:03:01 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Junfeng Guo <junfeng.guo@...el.com>
Cc: netdev@...r.kernel.org, jeroendb@...gle.com, pkaligineedi@...gle.com,
	shailend@...gle.com, haiyue.wang@...el.com
Subject: Re: [PATCH net] gve: Set default duplex configuration to full

On Thu, Jul 06, 2023 at 12:41:28PM +0800, Junfeng Guo wrote:
> Current duplex mode was unset in the driver, resulting in the default
> parameter being set to 0, which corresponds to half duplex. It might
> mislead users to have incorrect expectation about the driver's
> transmission capabilities.
> Set the default duplex configuration to full, as the driver runs in
> full duplex mode at this point.
> 
> Fixes: 7e074d5a76ca ("gve: Enable Link Speed Reporting in the driver.")
> Signed-off-by: Junfeng Guo <junfeng.guo@...el.com>
> ---
>  drivers/net/ethernet/google/gve/gve_ethtool.c | 3 +++
>  1 file changed, 3 insertions(+)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>