netdev - Re: [PATCH net] gve: unify driver name usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 7 Jul 2023 20:26:45 +0200
From: Michal Kubiak <michal.kubiak@...el.com>
To: Junfeng Guo <junfeng.guo@...el.com>
CC: <netdev@...r.kernel.org>, <jeroendb@...gle.com>,
	<pkaligineedi@...gle.com>, <shailend@...gle.com>, <haiyue.wang@...el.com>,
	<kuba@...nel.org>, <awogbemila@...gle.com>, <davem@...emloft.net>,
	<pabeni@...hat.com>, <yangchun@...gle.com>, <edumazet@...gle.com>,
	<csully@...gle.com>
Subject: Re: [PATCH net] gve: unify driver name usage

On Fri, Jul 07, 2023 at 06:37:10PM +0800, Junfeng Guo wrote:
> Current codebase contained the usage of two different names for this
> driver (i.e., `gvnic` and `gve`), which is quite unfriendly for users
> to use, especially when trying to bind or unbind the driver manually.
> The corresponding kernel module is registered with the name of `gve`.
> It's more reasonable to align the name of the driver with the module.
> 
> Fixes: 893ce44df565 ("gve: Add basic driver framework for Compute Engine Virtual NIC")
> Cc: csully@...gle.com
> Signed-off-by: Junfeng Guo <junfeng.guo@...el.com>
> ---
>

The patch makes the driver strings much more consistent.
Looks good to me.

Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>