netdev - Re: net: tipc: Remove repeated “initialization” in tipc_group_add_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 7 Jul 2023 08:42:59 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Christophe Jaillet <christophe.jaillet@...adoo.fr>,
 王明-软件底层技术部 <machel@...o.com>,
 opensource.kernel@...o.com, tipc-discussion@...ts.sourceforge.net,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Dan Carpenter <dan.carpenter@...aro.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Jon Maloy <jmaloy@...hat.com>,
 Paolo Abeni <pabeni@...hat.com>, Ying Xue <ying.xue@...driver.com>
Subject: Re: net: tipc: Remove repeated “initialization” in tipc_group_add_to_tree()

> The risk of breaking code (as you un-intentionally did) is higher than
> the value of removing a redundant initialization.

I find that it would be nicer to perform only required data processing steps.
The application of variable assignments can occasionally be improved further.

The corresponding efforts grow for proper code review.

The discussed change possibilities might belong to the adjustment category
“code cleanup”.
Some contributors have got difficulties to integrate presented ideas.
Thus it seems that more attractive incentives need to be offered
for potentially desirable software updates.

Regards,
Markus