netdev - Re: [PATCH v2] netconsole: Append kernel version to message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230707161050.61ec46a8@kernel.org>
Date: Fri, 7 Jul 2023 16:10:50 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
 <corbet@....net>, sergey.senozhatsky@...il.com, pmladek@...e.com,
 tj@...nel.org, stephen@...workplumber.org, Dave Jones
 <davej@...emonkey.org.uk>, netdev@...r.kernel.org (open list:NETWORKING
 [GENERAL]), linux-doc@...r.kernel.org (open list:DOCUMENTATION),
 linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH v2] netconsole: Append kernel version to message

On Fri,  7 Jul 2023 06:29:11 -0700 Breno Leitao wrote:
> Create a new netconsole runtime option that prepends the kernel version in
> the netconsole message. This is useful to map kernel messages to kernel
> version in a simple way, i.e., without checking somewhere which kernel
> version the host that sent the message is using.
> 
> If this option is selected, then the "<release>," is prepended before the
> netconsole message. This is an example of a netconsole output, with
> release feature enabled:
> 
> 	6.4.0-01762-ga1ba2ffe946e;12,426,112883998,-;this is a test
> 
> Calvin Owens send a RFC about this problem in 2016[1], but his
> approach was a bit more intrusive, changing the printk subsystem. This
> approach is lighter, and just append the information in the last mile,
> just before netconsole push the message to netpoll.
> 
> [1] Link: https://lore.kernel.org/all/51047c0f6e86abcb9ee13f60653b6946f8fcfc99.1463172791.git.calvinowens@fb.com/
> 
> Cc: Dave Jones <davej@...emonkey.org.uk>
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Looks good! net-next is closed for the duration of the merge window 
so you'll need to repost next week, and please put [PATCH net-next v3]
as the subject prefix while at it.

> @@ -332,6 +350,11 @@ static ssize_t enabled_store(struct config_item *item,
>  	}
>  
>  	if (enabled) {	/* true */
> +		if (nt->release && !nt->extended) {
> +			pr_err("release feature requires extended log message\n");
> +			goto out_unlock;
> +		}

This is the only bit that gave me pause - when parsing the command line
you ignore release if extended is not set (with an error/warning).
Does it make sense to be consistent and do the same thing here? 
Or enabling at runtime is fundamentally different?