netdev - Re: [PATCH net] net/mlx5: fix potential memory leak in mlx5e_init_rep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZKl1cgLB5mLXB/R7@corigine.com>
Date: Sat, 8 Jul 2023 15:40:50 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Zhengchao Shao <shaozhengchao@...wei.com>
Cc: netdev@...r.kernel.org, linux-rdma@...r.kernel.org, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	saeedm@...dia.com, leon@...nel.org, tariqt@...dia.com,
	lkayal@...dia.com, weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net] net/mlx5: fix potential memory leak in
 mlx5e_init_rep_rx

[Correct lkayal@...dia.com email address]

On Sat, Jul 08, 2023 at 03:13:07PM +0800, Zhengchao Shao wrote:
> The memory pointed to by the priv->rx_res pointer is not freed in the error
> path of mlx5e_init_rep_rx, which can lead to a memory leak. Fix by freeing
> the memory in the error path, thereby making the error path identical to
> mlx5e_cleanup_rep_rx().
> 
> Fixes: af8bbf730068 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>