netdev - Patch fixing STP if bridge in non-default namespace.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <608c37f9-34b1-85e6-2b4b-2a0389dd3d47@quietfountain.com>
Date: Mon, 10 Jul 2023 08:35:08 -0500
From: Harry Coin <hcoin@...etfountain.com>
To: netdev@...r.kernel.org
Subject: Patch fixing STP if bridge in non-default namespace.

Notice without access to link-level multicast address 01:80:C2:00:00:00, 
the STP loop-avoidance feature of bridges fails silently, leading to 
packet storms if loops exist in the related L2.  The Linux kernel's 
latest code silently drops BPDU STP packets if the bridge is in a 
non-default namespace.

The current llc_rcv.c around line 166 in net/llc/llc_input.c  has

        if (!net_eq(dev_net(dev), &init_net))
                goto drop;

Which, when commented out, fixes this bug.  A search on &init_net may 
reveal many similar artifacts left over from the early days of namespace 
implementation.

Thanks for all you do!

--