netdev - Re: [RFC 09/12] eth: bnxt: use the page pool for data pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230710100412.2cf439ae@kernel.org>
Date: Mon, 10 Jul 2023 10:04:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: netdev@...r.kernel.org, almasrymina@...gle.com, hawk@...nel.org,
 ilias.apalodimas@...aro.org, edumazet@...gle.com, dsahern@...il.com,
 willemb@...gle.com, Andrew Gospodarek <gospo@...adcom.com>, Somnath Kotur
 <somnath.kotur@...adcom.com>
Subject: Re: [RFC 09/12] eth: bnxt: use the page pool for data pages

On Sun, 9 Jul 2023 21:22:50 -0700 Michael Chan wrote:
> > -       if (BNXT_RX_PAGE_MODE(bp)) {
> > +       if (PAGE_SIZE <= BNXT_RX_PAGE_SIZE || BNXT_RX_PAGE_MODE(bp)) {  
> 
> We have a very similar set of patches from my colleague Somnath to
> support page pool and it supports PAGE_SIZE >= BNXT_RX_PAGE_SIZE in a
> more unified way.  So here, we don't have to deal with the if/else
> condition. I should be able to post the patches later in the week
> after some more QA.

I should have made it clearer, I'm testing with bnxt because of HW
availability but I have no strong need to get the bnxt bits merged
if it conflicts with your work.