netdev - Re: [PATCH net v3 0/2] net: sched: Undo tcf_bind_filter in case of errors in set callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6777febd-8f94-6f67-7eb3-7919c6125741@mojatatu.com>
Date: Mon, 10 Jul 2023 16:24:44 -0300
From: Victor Nogueira <victor@...atatu.com>
To: netdev@...r.kernel.org
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, pctammela@...atatu.com, simon.horman@...igine.com,
 kernel@...atatu.com
Subject: Re: [PATCH net v3 0/2] net: sched: Undo tcf_bind_filter in case of
 errors in set callbacks

Please ignore this patchset, I'll send a V4 soon with the approach we
discussed at the monthly tc meetup

cheers,
Victor


On 09/07/2023 13:13, Victor Nogueira wrote:
> BPF and flower classifier are calling tcf_bind_filter in their set
> callbacks, but aren't undoing it by calling tcf_unbind_filter if their
> was an error after binding.
> 
> This patch set fixes this by calling tcf_unbind_filter in such cases.
> 
> v1 -> v2:
> * Remove blank line after fixes tag
> * Fix reverse xmas tree issues pointed out by Simon
> 
> v2 -> v3:
> * Inlined functions cls_bpf_set_parms and fl_set_parms to avoid adding
>    yet another parameter (and a return value at it) to them.
> * Removed similar fixes for u32 and matchall, which will be sent soon,
>    once we find a way to do the fixes without adding a return parameter
>    to their set_parms functions.
> 
> Victor Nogueira (2):
>    net: sched: cls_bpf: Undo tcf_bind_filter in case of an error
>    net: sched: cls_flower: Undo tcf_bind_filter if fl_set_key fails
> 
>   net/sched/cls_bpf.c    | 99 ++++++++++++++++++++----------------------
>   net/sched/cls_flower.c | 99 ++++++++++++++++++++----------------------
>   2 files changed, 94 insertions(+), 104 deletions(-)
>