netdev - Re: [PATCH net-next v2 1/3] net: stmmac: dwmac-qcom-ethqos: Use of_get_phy_mode() over device_get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80fe2a99-67fd-4c8f-86c8-b097faa8be31@lunn.ch>
Date: Mon, 10 Jul 2023 22:59:43 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Andrew Halaney <ahalaney@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-stm32@...md-mailman.stormreply.com, netdev@...r.kernel.org,
	mcoquelin.stm32@...il.com, pabeni@...hat.com, kuba@...nel.org,
	edumazet@...gle.com, davem@...emloft.net, joabreu@...opsys.com,
	alexandre.torgue@...s.st.com, peppe.cavallaro@...com,
	bhupesh.sharma@...aro.org, vkoul@...nel.org,
	linux-arm-msm@...r.kernel.org, simon.horman@...igine.com
Subject: Re: [PATCH net-next v2 1/3] net: stmmac: dwmac-qcom-ethqos: Use
 of_get_phy_mode() over device_get_phy_mode()

On Mon, Jul 10, 2023 at 03:06:37PM -0500, Andrew Halaney wrote:
> Since this driver only uses devicetree, let's move over to
> of_get_phy_mode(). That API has an explicit error return and produces a
> phy_interface_t directly instead of an int when representing the phy
> mode.
> 
> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew