netdev - Re: [PATCH bpf-next v3 2/8] bpf: Add fd-based tcx multi-prog infra with link support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 10 Jul 2023 08:57:04 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: ast@...nel.org, andrii@...nel.org, martin.lau@...ux.dev,
 razor@...ckwall.org, sdf@...gle.com, john.fastabend@...il.com,
 kuba@...nel.org, dxu@...uu.xyz, joe@...ium.io, toke@...nel.org,
 davem@...emloft.net, bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v3 2/8] bpf: Add fd-based tcx multi-prog infra
 with link support

On 7/9/23 7:19 PM, Alexei Starovoitov wrote:
> On Fri, Jul 07, 2023 at 07:24:49PM +0200, Daniel Borkmann wrote:
>> diff --git a/net/Kconfig b/net/Kconfig
>> index 2fb25b534df5..d532ec33f1fe 100644
>> --- a/net/Kconfig
>> +++ b/net/Kconfig
>> @@ -52,6 +52,11 @@ config NET_INGRESS
>>   config NET_EGRESS
>>   	bool
>>   
>> +config NET_XGRESS
>> +	select NET_INGRESS
>> +	select NET_EGRESS
>> +	bool
> 
> Since new kconfig is needed, can NET_INGRESS and NET_EGRESS be removed at the same time?

No because netfilter can pick these individually :

config NETFILTER_INGRESS
         bool "Netfilter ingress support"
         default y
         select NET_INGRESS
         help
           This allows you to classify packets from ingress using the Netfilter
           infrastructure.

config NETFILTER_EGRESS
         bool "Netfilter egress support"
         default y
         select NET_EGRESS
         help
           This allows you to classify packets before transmission using the
           Netfilter infrastructure.

Thanks,
Daniel