netdev - Re: [PATCH net-next v2 02/10] net: atlantic: Remove unnecessary (void*) conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 10 Jul 2023 10:31:47 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Su Hui <suhui@...china.com>
Cc: irusskikh@...vell.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, yunchuan@...china.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next v2 02/10] net: atlantic: Remove unnecessary
 (void*) conversions

On Mon, Jul 10, 2023 at 02:39:52PM +0800, Su Hui wrote:
>  static void hw_atl2_hw_init_new_rx_filters(struct aq_hw_s *self)
>  {
> -	struct hw_atl2_priv *priv = (struct hw_atl2_priv *)self->priv;
>  	u8 *prio_tc_map = self->aq_nic_cfg->prio_tc_map;
> +	struct hw_atl2_priv *priv = self->priv;
>  	u16 action;
>  	u8 index;
>  	int i;

In this case moving the variable is fine because it's related to
removing the cast.  But in the other case it was moving other
decalarations so it wasn't related.

regards,
dan carpenter