netdev - Re: TC: selftests: current timeout (45s) is too low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 12 Jul 2023 16:02:43 +0200
From: Davide Caratti <dcaratti@...hat.com>
To: Pedro Tammela <pctammela@...atatu.com>
Cc: Matthieu Baerts <matthieu.baerts@...sares.net>, Jamal Hadi Salim <jhs@...atatu.com>, 
	Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, 
	netdev <netdev@...r.kernel.org>, Anders Roxell <anders.roxell@...aro.org>
Subject: Re: TC: selftests: current timeout (45s) is too low

hello!

On Wed, Jul 12, 2023 at 3:43 PM Pedro Tammela <pctammela@...atatu.com> wrote:
>
> Hi Matthieu,
>
> I have been involved in tdc for a while now, here are my comments.
>
> On 12/07/2023 06:47, Matthieu Baerts wrote:
> > Hi Jamal, Cong, Jiri,
> >
> > When looking for something else [1] in LKFT reports [2], I noticed that
> > the TC selftest ended with a timeout error:
> >
> >    not ok 1 selftests: tc-testing: tdc.sh # TIMEOUT 45 seconds
> >
> > The timeout has been introduced 3 years ago:
> >
> >    852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout
> > per test")
> >
> > Recently, a new option has been introduced to override the value when
> > executing the code:
> >
> >    f6a01213e3f8 ("selftests: allow runners to override the timeout")
> >
> > But I guess it is still better to set a higher default value for TC
> > tests. This is easy to fix by simply adding "timeout=<seconds>" in a
> > "settings" file in 'tc-testing' directory, e.g.
> >
> >    echo timeout=1200 > tools/testing/selftests/tc-testing/settings

finding a good default is not easy, because some kernel (e.g. those
built with debug options) are very slow .
Maybe we can leverage also on the other value in tdc_config.py [1] -
or at least ensure that the setting in 'setting' is consistent.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=d37e56df23f9e

[...]

> > I also noticed most of the tests were skipped [2], probably because
> > something is missing in the test environment? Do not hesitate to contact
> > the lkft team [3], that's certainly easy to fix and it would increase
> > the TC test coverage when they are validating all the different kernel
> > versions :)
>
>  From the logs it seems like the kernel image is missing the 'ct'
> action. Possibly also missing other actions/tc components, so it seems
> like a kernel config issue.

when I run tdc I use to do:

#  yes | make kselftest-merge

so that the kconfigs are not forgot :)

> Interestingly enough the `tdc.sh` script doesn't test the filter and
> infrastructure categories. Perhaps it would be better to let it run the
> entire suite instead of just a few tests.

I remember that the "filter" category was not stable enough when we
wrote tdc.sh. If it's in good shape now, we can surely add it.

thanks,
-- 
Davide