netdev - Re: [PATCH net] wifi: iwlwifi: remove 'use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZK7H1zISQ1yzkg4X@823b66c6476b>
Date: Wed, 12 Jul 2023 15:33:43 +0000
From: Rudi Heitbaum <rudi@...tbaum.com>
To: Johannes Berg <johannes@...solutions.net>
Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	Johannes Berg <johannes.berg@...el.com>,
	Xi Ruoyao <xry111@...111.site>,
	Niklāvs Koļesņikovs <pinkflames.linux@...il.com>,
	Jeff Chua <jeff.chua.linux@...il.com>,
	Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH net] wifi: iwlwifi: remove 'use_tfh' config to fix crash

On Mon, Jul 10, 2023 at 04:50:39PM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
> 
> This is equivalent to 'gen2', and it was always confusing to have
> two identical config entries. The split config patch actually had
> been originally developed after removing 'use_tfh" and didn't add
> the use_tfh in the new configs as they'd later been copied to the
> new files. Thus the easiest way to fix the init crash here now is
> to just remove use_tfh (which is erroneously unset in most of the
> configs now) and use 'gen2' in the code instead.
> 
> There's possibly still an unwind error in iwl_txq_gen2_init() as
> it crashes if TXQ 0 fails to initialize, but we can deal with it
> later since the original failure is due to the use_tfh confusion.
> 
> Tested-by: Xi Ruoyao <xry111@...111.site>
> Reported-and-tested-by: Niklāvs Koļesņikovs <pinkflames.linux@...il.com>
> Reported-and-tested-by: Jeff Chua <jeff.chua.linux@...il.com>
> Reported-and-tested-by: Zhang Rui <rui.zhang@...el.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217622
> Link: https://lore.kernel.org/all/9274d9bd3d080a457649ff5addcc1726f08ef5b2.camel@xry111.site/
> Link: https://lore.kernel.org/all/CAAJw_Zug6VCS5ZqTWaFSr9sd85k%3DtyPm9DEE%2BmV%3DAKoECZM%2BsQ@mail.gmail.com/
> Fixes: 19898ce9cf8a ("wifi: iwlwifi: split 22000.c into multiple files")
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Hi Johannes,

I can confirm that this is now working with 83.e8f84e98.0 so-a0-gf-a0-83.ucode.
it wasnt with 6.5-rc1 and both 78 and 83 firmwares.

Tested-by: Rudi Heitbaum <rudi@...tbaum.com>