netdev - Re: [PATCH net-next 3/3] eth: bnxt: handle invalid Tx completions more gracefully

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230712093506.6a1f229a@kernel.org>
Date: Wed, 12 Jul 2023 09:35:06 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com
Subject: Re: [PATCH net-next 3/3] eth: bnxt: handle invalid Tx completions
 more gracefully

On Tue, 11 Jul 2023 21:50:16 -0700 Michael Chan wrote:
> > Are you saying that in ethtool -S in addition to per-ring counts
> > we'd report a "total" which is sum(current per ring) + saved?
> > If so - that makes sense, yup.  
> 
> Yes, for example, we have "rx_resets" which is per ring.  We'll add a
> "rx_total_resets" which is the sum of all current "rx_resets" + the
> saved snapshot.  The per ring "rx_resets" will reset to 0 during each
> reset (including ifdown).  But "rx_total_resets" will be saved across
> reset.
> 
> > You mention reset but the errors counters should survive close() /
> > open() cycles as well.  
> 
> Yes.  It's the same reset whether it is ifdown/ifup or reset.

Makes sense, and sounds good!