netdev - Re: [PATCH net 07/12] inet: frags: remove kernel-doc comment marker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1b99cea-0abc-a94a-7f59-28340aaf2cfe@infradead.org>
Date: Tue, 11 Jul 2023 20:48:07 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Nikolay Aleksandrov <razor@...ckwall.org>
Subject: Re: [PATCH net 07/12] inet: frags: remove kernel-doc comment marker

On 7/11/23 20:34, Jakub Kicinski wrote:
> On Mon, 10 Jul 2023 16:03:07 -0700 Randy Dunlap wrote:
>> -/**
>> +/*
>>   * fragment queue flags
> 
> Can we do:
> 
> 	enum: fragment queue flags
> 
> instead? This seems to get accepted by ./scripts/kernel-doc and it's
> nice to keep the "syntax" highlight of the comment, IMHO.

That's not quite kernel-doc syntax but we don't have syntax for an
anonymous enum. But you are correct, kernel-doc isn't complaining
about it, so OK, I can send a v2.

thanks.
-- 
~Randy