netdev - Re: [PATCH net-next 1/4] security: Constify sk in the sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZK/Eo3yOWaSHywXi@corigine.com>
Date: Thu, 13 Jul 2023 10:32:19 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Guillaume Nault <gnault@...hat.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org, Paul Moore <paul@...l-moore.com>,
	Eric Paris <eparis@...isplace.org>,
	linux-security-module@...r.kernel.org, selinux@...r.kernel.org
Subject: Re: [PATCH net-next 1/4] security: Constify sk in the sk_getsecid
 hook.

On Tue, Jul 11, 2023 at 03:06:08PM +0200, Guillaume Nault wrote:
> The sk_getsecid hook shouldn't need to modify its socket argument.
> Make it const so that callers of security_sk_classify_flow() can use a
> const struct sock *.
> 
> Signed-off-by: Guillaume Nault <gnault@...hat.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>