netdev - Re: [PATCH v1 net-next] ipv6: rpl: Remove redundant skb_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZK+7hJM/PhCaS72X@corigine.com>
Date: Thu, 13 Jul 2023 09:53:24 +0100
From: Simon Horman <simon.horman@...igine.com>
To: David Ahern <dsahern@...nel.org>
Cc: Kuniyuki Iwashima <kuniyu@...zon.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next] ipv6: rpl: Remove redundant skb_dst_drop().

On Wed, Jul 12, 2023 at 08:42:27AM -0600, David Ahern wrote:
> On 7/12/23 5:39 AM, Simon Horman wrote:
> > On Mon, Jul 10, 2023 at 02:35:11PM -0700, Kuniyuki Iwashima wrote:
> >> RPL code has a pattern where skb_dst_drop() is called before
> >> ip6_route_input().
> >>
> >> However, ip6_route_input() calls skb_dst_drop() internally,
> >> so we need not call skb_dst_drop() before ip6_route_input().
> >>
> >> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> > 
> > Reviewed-by: Simon Horman <simon.horman@...igine.com>
> > 
> 
> I have been ignoring net-next patches since net-next status still shows
> as closed.

Yes, sorry that I may have been a bit hasty there.