netdev - Re: [PATCH net-next v4 1/5] net: sched: cls_matchall: Undo tcf_bind_filter in case of failure after mall_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jul 2023 10:17:00 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Victor Nogueira <victor@...atatu.com>
Cc: netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
	jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, pctammela@...atatu.com,
	kernel@...atatu.com
Subject: Re: [PATCH net-next v4 1/5] net: sched: cls_matchall: Undo
 tcf_bind_filter in case of failure after mall_set_parms

On Wed, Jul 12, 2023 at 06:13:09PM -0300, Victor Nogueira wrote:
> In case an error occurred after mall_set_parms executed successfully, we
> must undo the tcf_bind_filter call it issues.
> 
> Fix that by calling tcf_unbind_filter in err_replace_hw_filter label.
> 
> Fixes: ec2507d2a306 ("net/sched: cls_matchall: Fix error path")
> Signed-off-by: Victor Nogueira <victor@...atatu.com>
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
> Reviewed-by: Pedro Tammela <pctammela@...atatu.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>