netdev - RE: [PATCH net-next] tools: ynl-gen: fix parse multi-attr enum attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB46573D08DCCC3F4280BBB4189B37A@DM6PR11MB4657.namprd11.prod.outlook.com>
Date: Thu, 13 Jul 2023 09:22:55 +0000
From: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"chuck.lever@...cle.com" <chuck.lever@...cle.com>
Subject: RE: [PATCH net-next] tools: ynl-gen: fix parse multi-attr enum
 attribute

>From: Jakub Kicinski <kuba@...nel.org>
>Sent: Wednesday, July 12, 2023 6:24 PM
>To: Kubalewski, Arkadiusz <arkadiusz.kubalewski@...el.com>
>Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org;
>davem@...emloft.net; pabeni@...hat.com; edumazet@...gle.com;
>chuck.lever@...cle.com
>Subject: Re: [PATCH net-next] tools: ynl-gen: fix parse multi-attr enum
>attribute
>
>On Wed, 12 Jul 2023 09:47:43 +0000 Kubalewski, Arkadiusz wrote:
>> >+            if 'enum' in attr_spec:
>> >+                decoded = self._decode_enum(rsp, attr_spec)
>
>To be clear - this is just a quick mock up, you'll need to change
>the arguments here, obviously. Probably to decoded and attr_spec?

Well I did something that works for me:
("[PATCH net-next 0/2] tools: ynl-gen: fix parse multi-attr enum attribute")

But I am pretty sure it could break the other _decode_enum call
(from _decode_binary(..)), wasn't able to test it yet, as it seems to be used
only with ovs_flow.yaml spec (binary + struct type attr).

If you could take a look would be great.

Thank you!
Arkadiusz