netdev - Re: [PATCH] net: lan966x: fix parameter check in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bf902af-ee7f-bb44-49d7-db96c0a5c6ea@web.de>
Date: Thu, 13 Jul 2023 15:15:22 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Minjie Du <duminjie@...o.com>, opensource.kernel@...o.com,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
 UNGLinuxDriver@...rochip.com, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Horatiu Vultur <horatiu.vultur@...rochip.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Richard Cochran <richardcochran@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: lan966x: fix parameter check in two functions

> Make IS_ERR_OR_NULL() judge the vcap_get_rule() function return

Would the term “return value” be relevant here?

Would you like to improve this change description also according to
review comments from other patches?

How do you think about to add the tag “Fixes” because of a desirable
source code adjustment?

Would a subject like “[PATCH v2] net: lan966x: Fix an error check in two functions
be more appropriate?

Regards,
Markus