netdev - Re: 回复: [PATCH net v1] bna:Fix error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d83f5767-a98f-a258-f0c4-e7228345b93f@infradead.org>
Date: Thu, 13 Jul 2023 07:34:08 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: 王明-软件底层技术部 <machel@...o.com>
Cc: Rasesh Mody <rmody@...vell.com>, Sudarsana Kalluru
 <skalluru@...vell.com>,
 "GR-Linux-NIC-Dev@...vell.com" <GR-Linux-NIC-Dev@...vell.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Krishna Gudipati <kgudipat@...cade.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: 回复: [PATCH net v1] bna:Fix error checking for debugfs_create_dir()



On 7/13/23 02:05, 王明-软件底层技术部 wrote:
> Ok, so I think we should delete the check operation. What do you think? If it is consistent, I will submit it again
> : )

Yes, that's the idea. Thanks.

> Ming
> -----邮件原件-----
> 发件人: Randy Dunlap <rdunlap@...radead.org> 
> 发送时间: 2023年7月13日 13:50
> 收件人: 王明-软件底层技术部 <machel@...o.com>; Rasesh Mody <rmody@...vell.com>; Sudarsana Kalluru <skalluru@...vell.com>; GR-Linux-NIC-Dev@...vell.com; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Krishna Gudipati <kgudipat@...cade.com>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> 抄送: opensource.kernel <opensource.kernel@...o.com>
> 主题: Re: [PATCH net v1] bna:Fix error checking for debugfs_create_dir()
> 
> [Some people who received this message don't often get email from rdunlap@...radead.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hi--
> 
> On 7/12/23 22:38, Wang Ming wrote:
>> The debugfs_create_dir() function returns error pointers, it never 
>> returns NULL. Most incorrect error checks were fixed, but the one in 
>> bnad_debugfs_init() was forgotten.
>>
>> Fix the remaining error check.
>>
>> Signed-off-by: Wang Ming <machel@...o.com>
>>
>> Fixes: 7afc5dbde091 ("bna: Add debugfs interface.")
> 
> Comment from fs/debugfs/inode.c:
> 
>  * NOTE: it's expected that most callers should _ignore_ the errors returned
>  * by this function. Other debugfs functions handle the fact that the "dentry"
>  * passed to them could be an error and they don't crash in that case.
>  * Drivers should generally work fine even if debugfs fails to init anyway.
> 
> so no, drivers should not usually care about debugfs function call results.
> Is there some special case here?
> 
>> ---
>>  drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c 
>> b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
>> index 04ad0f2b9677..678a3668a041 100644
>> --- a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
>> +++ b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
>> @@ -512,7 +512,7 @@ bnad_debugfs_init(struct bnad *bnad)
>>       if (!bnad->port_debugfs_root) {
>>               bnad->port_debugfs_root =
>>                       debugfs_create_dir(name, bna_debugfs_root);
>> -             if (!bnad->port_debugfs_root) {
>> +             if (IS_ERR(bnad->port_debugfs_root)) {
>>                       netdev_warn(bnad->netdev,
>>                                   "debugfs root dir creation failed\n");
>>                       return;
> 
> --
> ~Randy

-- 
~Randy