netdev - Re: [PATCH] drivers/net: marvell: mvpp2: fix debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jul 2023 17:43:08 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Minjie Du <duminjie@...o.com>, opensource.kernel@...o.com,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Marcin Wojtas <mw@...ihalf.com>,
 Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/net: marvell: mvpp2: fix debugfs_create_dir()
 return check in three functions

> Make IS_ERR() judge the debugfs_create_dir() function return

Would the term “return value” be relevant here?

Would you like to improve this change description also according to
review comments from other patches?

How do you think about to add the tag “Fixes” because of corrected error detections?

Would a subject like “[PATCH v2] net: mvpp2: debugfs: Fix error checks in three functions”
be more appropriate?

> Line 562 deletes the space because checkpatch reports an error.

Please put this adjustment into a separate update step
(also with a better wording).

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n81

Regards,
Markus