netdev - Re: [PATCH net 2/2] team: reset team's flags when down link is P2P device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 14 Jul 2023 08:48:52 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
	"David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>, Liang Li <liali@...hat.com>,
	Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net 2/2] team: reset team's flags when down link is P2P
 device

Fri, Jul 14, 2023 at 04:52:01AM CEST, liuhangbin@...il.com wrote:
>When adding a point to point downlink to team device, we neglected to reset
>the team's flags, which were still using flags like BROADCAST and
>MULTICAST. Consequently, this would initiate ARP/DAD for P2P downlink
>interfaces, such as when adding a GRE device to team device.
>
>Fix this by remove multicast/broadcast flags and add p2p and noarp flags.
>
>Reported-by: Liang Li <liali@...hat.com>
>Links: https://bugzilla.redhat.com/show_bug.cgi?id=2221438
>Fixes: 1d76efe1577b ("team: add support for non-ethernet devices")
>Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>