netdev - RE: [Intel-wired-lan] [PATCH net v2] ice: Unregister netdev and devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 14 Jul 2023 08:59:38 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: poros <poros@...hat.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "davem@...emloft.net"
	<davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net v2] ice: Unregister netdev and
 devlink_port only once

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Petr Oros
> Sent: Monday, June 19, 2023 4:28 PM
> To: netdev@...r.kernel.org
> Cc: pmenzel@...gen.mpg.de; intel-wired-lan@...ts.osuosl.org; Brandeburg, Jesse <jesse.brandeburg@...el.com>; linux-kernel@...r.kernel.org; edumazet@...gle.com; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; kuba@...nel.org; pabeni@...hat.com; davem@...emloft.net
> Subject: [Intel-wired-lan] [PATCH net v2] ice: Unregister netdev and devlink_port only once
>
> Since commit 6624e780a577fc ("ice: split ice_vsi_setup into smaller
> functions") ice_vsi_release does things twice. There is unregister netdev which is unregistered in ice_deinit_eth also.
>
> It also unregisters the devlink_port twice which is also unregistered in ice_deinit_eth(). This double deregistration is hidden because devl_port_unregister ignores the return value of xa_erase.
>
> [   68.642167] Call Trace:
> [   68.650385]  ice_devlink_destroy_pf_port+0xe/0x20 [ice]
> [   68.655656]  ice_vsi_release+0x445/0x690 [ice]
> [   68.660147]  ice_deinit+0x99/0x280 [ice]
> [   68.664117]  ice_remove+0x1b6/0x5c0 [ice]
>
> [  171.103841] Call Trace:
> [  171.109607]  ice_devlink_destroy_pf_port+0xf/0x20 [ice] [  171.114841]  ice_remove+0x158/0x270 [ice] [  171.118854]  pci_device_remove+0x3b/0xc0 [  171.122779]  device_release_driver_internal+0xc7/0x170
> [  171.127912]  driver_detach+0x54/0x8c
> [  171.131491]  bus_remove_driver+0x77/0xd1 [  171.135406]  pci_unregister_driver+0x2d/0xb0 [  171.139670]  ice_module_exit+0xc/0x55f [ice]
>
> Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions")
> Signed-off-by: Petr Oros <poros@...hat.com>
> ---
> v2: reword subject
>
> v1: https://lore.kernel.org/netdev/20230619084948.360128-1-poros@redhat.com/
> ---
> drivers/net/ethernet/intel/ice/ice_lib.c | 27 ------------------------
> 1 file changed, 27 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)