netdev - Re: [PATCH net v3] net: thunder: bgx: Fix resource leaks in device_for_each_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 14 Jul 2023 15:06:08 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Wang Ming <machel@...o.com>, opensource.kernel@...o.com,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, David Daney <david.daney@...ium.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Sunil Goutham <sgoutham@...vell.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Minjie Du <duminjie@...o.com>
Subject: Re: [PATCH net v3] net: thunder: bgx: Fix resource leaks in
 device_for_each_child_node() loops

> The device_for_each_child_node() loop in bgx_init_of_phy()
> function should have fwnode_handle_put() before break which could
> avoid resource leaks. This patch could fix this bug.

Are imperative change descriptions still preferred?

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94

Regards,
Markus