lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230714083152.3f64d38a@kernel.org>
Date: Fri, 14 Jul 2023 08:31:52 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jesper Dangaard Brouer <jbrouer@...hat.com>
Cc: Haiyang Zhang <haiyangz@...rosoft.com>, brouer@...hat.com,
 "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Dexuan Cui
 <decui@...rosoft.com>, KY Srinivasan <kys@...rosoft.com>, Paul Rosswurm
 <paulros@...rosoft.com>, "olaf@...fle.de" <olaf@...fle.de>,
 "vkuznets@...hat.com" <vkuznets@...hat.com>, "davem@...emloft.net"
 <davem@...emloft.net>, "wei.liu@...nel.org" <wei.liu@...nel.org>,
 "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "leon@...nel.org" <leon@...nel.org>, Long Li
 <longli@...rosoft.com>, "ssengar@...ux.microsoft.com"
 <ssengar@...ux.microsoft.com>, "linux-rdma@...r.kernel.org"
 <linux-rdma@...r.kernel.org>, "daniel@...earbox.net"
 <daniel@...earbox.net>, "john.fastabend@...il.com"
 <john.fastabend@...il.com>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
 "ast@...nel.org" <ast@...nel.org>, Ajay Sharma <sharmaajay@...rosoft.com>,
 "hawk@...nel.org" <hawk@...nel.org>, "tglx@...utronix.de"
 <tglx@...utronix.de>, "shradhagupta@...ux.microsoft.com"
 <shradhagupta@...ux.microsoft.com>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, Ilias Apalodimas
 <ilias.apalodimas@...aro.org>
Subject: Re: [PATCH net-next] net: mana: Add page pool for RX buffers

On Fri, 14 Jul 2023 15:13:15 +0200 Jesper Dangaard Brouer wrote:
> > Thank Jakub and Jesper for the reviews.
> > I'm aware of the page_pool.rst doc, and actually tried it before this
> > patch, but I got lower perf. If I understand correctly, we should call
> > page_pool_release_page() before passing the SKB to napi_gro_receive().
> > 
> > I found the page_pool_dev_alloc_pages() goes through the slow path,
> > because the page_pool_release_page() let the page leave the pool.
> > 
> > Do we have to call page_pool_release_page() before passing the SKB
> > to napi_gro_receive()? Any better way to recycle the pages from the
> > upper layer of non-XDP case?
> >   
> 
> Today SKB "upper layers" can recycle page_pool backed packet data/page.
> 
> Just use skb_mark_for_recycle(skb), then you don't need 
> page_pool_release_page().
> 
> I guess, we should update the documentation, mentioning this.

Ah, I should probably send in the few cleanups form the huge page
series. It looks like all users of page_pool_release_page() can
be converted to skb recycling, so we should hide it and remove 
from docs?

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ