netdev - Re: [PATCH iproute2] misc/ifstat: ignore json

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 14 Jul 2023 09:04:25 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Chander Govindarajan <mail@...ndergovind.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] misc/ifstat: ignore json_output when run using
 "-d"

On Mon, 10 Jul 2023 16:15:22 +0530
Chander Govindarajan <mail@...ndergovind.org> wrote:

> If ifstat is run with a command like:
> ifstat -d 5 -j
> 
> subsequent commands (with or without the "-j" flag) fail with:
> Aborted (core dumped)
> 
> Unsets json_ouput when using the "-d" flag. Also, since the "-d"
> daemon behaviour is not immediately obvious, add a 1 line
> description in the man page.
> 
> Signed-off-by: ChanderG <mail@...ndergovind.org>

Was about to apply this but there a couple of problems.

First, in the Signed-off-by: it should have your legal name.
Is it supposed to be "Chander Govind <mail@...ndergovind.org>"?


> ---
>   man/man8/ifstat.8 | 3 +++
>   misc/ifstat.c     | 1 +
>   2 files changed, 4 insertions(+)
> 
> diff --git a/man/man8/ifstat.8 b/man/man8/ifstat.8
> index 8cd164dd..2deeb3b5 100644
> --- a/man/man8/ifstat.8
> +++ b/man/man8/ifstat.8
> @@ -16,6 +16,9 @@ by default only shows difference between the last and 
> the current call.
>   Location of the history files defaults to /tmp/.ifstat.u$UID but may be
>   overridden with the IFSTAT_HISTORY environment variable. Similarly, 
> the default
>   location for xstat (extended stats) is /tmp/.<xstat name>_ifstat.u$UID.

What ever you used to make the patch or send it got messed up here.
There is a missing newline, causing git (and patch) command to report
that this is a malformed patch.