netdev - Re: [PATCH net 2/3] selftests: tc: add 'ct' action kconfig dep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d5a0d6c-1dcd-7a0d-1f5c-a38e0e15fd85@huawei.com>
Date: Fri, 14 Jul 2023 10:56:56 +0800
From: shaozhengchao <shaozhengchao@...wei.com>
To: Matthieu Baerts <matthieu.baerts@...sares.net>, Jamal Hadi Salim
	<jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko
	<jiri@...nulli.us>, Shuah Khan <shuah@...nel.org>, Kees Cook
	<keescook@...omium.org>, "David S. Miller" <davem@...emloft.net>, Paul Blakey
	<paulb@...lanox.com>, Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
	<mptcp@...ts.linux.dev>
CC: Pedro Tammela <pctammela@...atatu.com>, Shuah Khan
	<skhan@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH net 2/3] selftests: tc: add 'ct' action kconfig dep



On 2023/7/14 5:16, Matthieu Baerts wrote:
> When looking for something else in LKFT reports [1], I noticed most of
> the tests were skipped because the "teardown stage" did not complete
> successfully.
> 
> Pedro found out this is due to the fact CONFIG_NF_FLOW_TABLE is required
> but not listed in the 'config' file. Adding it to the list fixes the
> issues on LKFT side. CONFIG_NET_ACT_CT is now set to 'm' in the final
> kconfig.
> 
> Fixes: c34b961a2492 ("net/sched: act_ct: Create nf flow table per zone")
> Cc: stable@...r.kernel.org
> Link: https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230711/testrun/18267241/suite/kselftest-tc-testing/test/tc-testing_tdc_sh/log [1]
> Link: https://lore.kernel.org/netdev/0e061d4a-9a23-9f58-3b35-d8919de332d7@tessares.net/T/ [2]
> Suggested-by: Pedro Tammela <pctammela@...atatu.com>
> Signed-off-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> ---
>   tools/testing/selftests/tc-testing/config | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config
> index 6e73b09c20c8..d1ad29040c02 100644
> --- a/tools/testing/selftests/tc-testing/config
> +++ b/tools/testing/selftests/tc-testing/config
> @@ -5,6 +5,7 @@ CONFIG_NF_CONNTRACK=m
>   CONFIG_NF_CONNTRACK_MARK=y
>   CONFIG_NF_CONNTRACK_ZONES=y
>   CONFIG_NF_CONNTRACK_LABELS=y
> +CONFIG_NF_FLOW_TABLE=m
>   CONFIG_NF_NAT=m
>   CONFIG_NETFILTER_XT_TARGET_LOG=m
>   
> 

Tested-by: Zhengchao Shao <shaozhengchao@...wei.com>