netdev - Re: [PATCH net] r8169: fix ASPM-related problem for chip version 42 and 43

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d644f048-970c-71fe-a556-a2c80444dae2@leemhuis.info>
Date: Fri, 14 Jul 2023 05:31:52 +0200
From: "Linux regression tracking (Thorsten Leemhuis)"
 <regressions@...mhuis.info>
To: Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org>,
 David Miller <davem@...emloft.net>,
 Realtek linux nic maintainers <nic_swsd@...ltek.com>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Linux regressions mailing list <regressions@...ts.linux.dev>,
 joey.joey586@...il.com
Subject: Re: [PATCH net] r8169: fix ASPM-related problem for chip version 42
 and 43

On 13.07.23 21:46, Heiner Kallweit wrote:
> Referenced commit missed that for chip versions 42 and 43 ASPM

Thanks again for taking care of this.

> [0] https://bugzilla.kernel.org/show_bug.cgi?id=217635

That line should be a proper Link: or Closes: tag, as explained by
Documentation/process/submitting-patches.rst
(http://docs.kernel.org/process/submitting-patches.html) and
Documentation/process/5.Posting.rst
(https://docs.kernel.org/process/5.Posting.html) and thus be in the
signed-off-by area, for example like this (without the space upfront):

> Fixes: 5fc3f6c90cca ("r8169: consolidate disabling ASPM before EPHY access")
 Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217635 # [0]

A "Cc: stable@...r.kernel.org" would be nice, too, to get this fixed in
6.4, where this surfaced (reminder: no, a Fixes: tag is not enough to
ensure the backport there).

> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> […]

#regzbot ^backmonitor: https://bugzilla.kernel.org/show_bug.cgi?id=217635

Ciao, Thorsten