netdev - Re: [PATCH net-next] net: mana: Add page pool for RX buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 13 Jul 2023 20:53:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Dexuan Cui
 <decui@...rosoft.com>, KY Srinivasan <kys@...rosoft.com>, Paul Rosswurm
 <paulros@...rosoft.com>, "olaf@...fle.de" <olaf@...fle.de>,
 "vkuznets@...hat.com" <vkuznets@...hat.com>, "davem@...emloft.net"
 <davem@...emloft.net>, "wei.liu@...nel.org" <wei.liu@...nel.org>,
 "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "leon@...nel.org" <leon@...nel.org>, Long Li
 <longli@...rosoft.com>, "ssengar@...ux.microsoft.com"
 <ssengar@...ux.microsoft.com>, "linux-rdma@...r.kernel.org"
 <linux-rdma@...r.kernel.org>, "daniel@...earbox.net"
 <daniel@...earbox.net>, "john.fastabend@...il.com"
 <john.fastabend@...il.com>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
 "ast@...nel.org" <ast@...nel.org>, Ajay Sharma <sharmaajay@...rosoft.com>,
 "hawk@...nel.org" <hawk@...nel.org>, "tglx@...utronix.de"
 <tglx@...utronix.de>, "shradhagupta@...ux.microsoft.com"
 <shradhagupta@...ux.microsoft.com>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: mana: Add page pool for RX buffers

On Thu, 13 Jul 2023 14:48:45 +0000 Haiyang Zhang wrote:
> Add page pool for RX buffers for faster buffer cycle and reduce CPU
> usage.
> 
> Get an extra ref count of a page after allocation, so after upper
> layers put the page, it's still referenced by the pool. We can reuse
> it as RX buffer without alloc a new page.

Please use the real page_pool API from include/net/page_pool.h
We've moved past every driver reinventing the wheel, sorry.
-- 
pw-bot: cr