netdev - Re: [PATCH v2 net] gso: fix dodgy bit handling for GSO_UDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEvq8h_yYhxBWD4oPBBwE8xzDMt7VqbW4wz+oqjfYbiQfQ@mail.gmail.com>
Date: Fri, 14 Jul 2023 11:58:46 +0800
From: Jason Wang <jasowang@...hat.com>
To: Yan Zhai <yan@...udflare.com>
Cc: "open list:NETWORKING [TCP]" <netdev@...r.kernel.org>, kernel-team@...udflare.com, 
	Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, 
	David Ahern <dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Xin Long <lucien.xin@...il.com>, 
	Herbert Xu <herbert@...dor.apana.org.au>, Andrew Melnychenko <andrew@...nix.com>, 
	Willem de Bruijn <willemdebruijn.kernel@...il.com>, open list <linux-kernel@...r.kernel.org>, 
	"open list:SCTP PROTOCOL" <linux-sctp@...r.kernel.org>
Subject: Re: [PATCH v2 net] gso: fix dodgy bit handling for GSO_UDP_L4

On Fri, Jul 14, 2023 at 1:28 AM Yan Zhai <yan@...udflare.com> wrote:
>
> Commit 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4
> packets.") checks DODGY bit for UDP, but for packets that can be fed
> directly to the device after gso_segs reset, it actually falls through
> to fragmentation:
>
> https://lore.kernel.org/all/CAJPywTKDdjtwkLVUW6LRA2FU912qcDmQOQGt2WaDo28KzYDg+A@mail.gmail.com/
>
> This change restores the expected behavior of GSO_UDP_L4 packets.
>
> Fixes: 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4 packets.")
> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Signed-off-by: Yan Zhai <yan@...udflare.com>
>
> ---
> v2: dropped modifications to tcp/sctp on DODGY bit removal after
> validating gso_segs. Also moved the UDP header check into
> __udp_gso_segment (per Willem's suggestion).
>

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks