netdev - Re: Query on acpi support for dsa driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 15 Jul 2023 01:01:35 +0200
From: Andrew Lunn <andrew@...n.ch>
To: SIMON BABY <simonkbaby@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: Query on acpi support for dsa driver

On Fri, Jul 14, 2023 at 12:38:24PM -0700, SIMON BABY wrote:
> Hello Team ,

> I am new to this group . I have a query on adding a switch device (
> microchip EVB-KSZ9897) to my Intel based x86 board which uses ACPI
> instead of device tree. The Intel x86 is running Linux Ubuntu 5.15
> kernel .

> Do I need any changes in the drive code to get the acpi table and
> invoke the functions ? When I looked the code
> drivers/net/dsa/microchip/ksz9477_i2c.c it has support only for DSA.

> Please provide your inputs .

ACPI is generally not used for networking. Nobody who cares enough
about ACPI has taken the time to understand the DT concepts, find the
equivalent in ACPI, write a proposal to extend the ACPI standard, get
it accepted in, and then done the implementation work.

What some people have tried in the past is just accept DT is the way
describe this sort of hardware, and stuff all the DT properties into
ACPI tables. But they often do it wrongly, including all the DT
legacy, deprecated properties etc.

The mv88e6xxx driver can be instantiated via a platform driver. I have
a couple of x86 targets with drivers placed in drivers/platform/x86
which instantiate mv88e6xxx instances. For simple setups, using just
the internal PHYs that is sufficient.

Take a look at drivers/platform/x86/asus-tf103c-dock.c and how it uses
i2c_new_client_device() to instantiate i2c devices. And
mv88e6xxx_probe() and its use of pdata.

	Andrew