netdev - Re: [PATCH v12 03/26] net/ethtool: add ULP_DDP_{GET,SET} operations for caps and stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 15 Jul 2023 11:14:21 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Aurelien Aptel <aaptel@...dia.com>
Cc: linux-nvme@...ts.infradead.org, netdev@...r.kernel.org,
	sagi@...mberg.me, hch@....de, kbusch@...nel.org, axboe@...com,
	chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org,
	aurelien.aptel@...il.com, smalin@...dia.com, malin1024@...il.com,
	ogerlitz@...dia.com, yorayz@...dia.com, borisp@...dia.com,
	galshalom@...dia.com, mgurtovoy@...dia.com
Subject: Re: [PATCH v12 03/26] net/ethtool: add ULP_DDP_{GET,SET} operations
 for caps and stats

On Wed, Jul 12, 2023 at 04:14:50PM +0000, Aurelien Aptel wrote:

...

> diff --git a/net/ethtool/ulp_ddp.c b/net/ethtool/ulp_ddp.c
> new file mode 100644
> index 000000000000..e5451689fef9
> --- /dev/null
> +++ b/net/ethtool/ulp_ddp.c

...

> +static int ulp_ddp_put_stats64(struct sk_buff *skb, int attrtype, const u64 *val,
> +			       unsigned int count)
> +{
> +	struct nlattr *nest;
> +	unsigned int i, attr;

nit: please use reverse xmas tree - longest line to shortest -
     for local variable declarations in Networking code.