netdev - Re: [PATCH iproute2 v2] misc/ifstat: fix incorrect output data in json mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04c8e339-1811-b069-c833-99c7ab7060e3@chandergovind.org>
Date: Mon, 17 Jul 2023 15:02:46 +0530
From: Chander Govindarajan <mail@...ndergovind.org>
To: netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2 v2] misc/ifstat: fix incorrect output data in
 json mode

Due to this bug, in json mode (with the -j flag), the output was
always in absolute mode (as if passing in the -a flag) and not in
relative mode.

Signed-off-by: Chander Govindarajan <mail@...ndergovind.org>
---
 misc/ifstat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/misc/ifstat.c b/misc/ifstat.c
index f6f9ba50..6c76fa15 100644
--- a/misc/ifstat.c
+++ b/misc/ifstat.c
@@ -569,7 +569,7 @@ static void dump_incr_db(FILE *fp)
 			continue;
 
 		if (jw)
-			print_one_json(jw, n, n->val);
+			print_one_json(jw, n, vals);
 		else
 			print_one_if(fp, n, vals);
 	}
-- 
2.36.1.299.gab336e8f1c