netdev - Re: [PATCH v12 03/26] net/ethtool: add ULP_DDP_{GET,SET} operations for caps and stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <253edl6swfi.fsf@mtr-vdi-124.i-did-not-set--mail-host-address--so-tickle-me>
Date: Mon, 17 Jul 2023 12:45:53 +0300
From: Aurelien Aptel <aaptel@...dia.com>
To: Simon Horman <simon.horman@...igine.com>
Cc: linux-nvme@...ts.infradead.org, netdev@...r.kernel.org,
 sagi@...mberg.me, hch@....de, kbusch@...nel.org, axboe@...com,
 chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org,
 aurelien.aptel@...il.com, smalin@...dia.com, malin1024@...il.com,
 ogerlitz@...dia.com, yorayz@...dia.com, borisp@...dia.com,
 galshalom@...dia.com, mgurtovoy@...dia.com
Subject: Re: [PATCH v12 03/26] net/ethtool: add ULP_DDP_{GET,SET} operations
 for caps and stats

Simon Horman <simon.horman@...igine.com> writes:
>> +     struct nlattr *nest;
>> +     unsigned int i, attr;
>
> nit: please use reverse xmas tree - longest line to shortest -
>      for local variable declarations in Networking code.

I'll fix it, thanks