netdev - RE: [Intel-wired-lan] [PATCH iwl-next v2] ice: Accept LAG netdevs in bridge offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW4PR11MB57767325A9110C71C3539128FD3BA@MW4PR11MB5776.namprd11.prod.outlook.com>
Date: Mon, 17 Jul 2023 09:36:44 +0000
From: "Drewek, Wojciech" <wojciech.drewek@...el.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"jiri@...nulli.us" <jiri@...nulli.us>, "simon.horman@...igine.com"
	<simon.horman@...igine.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v2] ice: Accept LAG netdevs in
 bridge offloads



> -----Original Message-----
> From: Paul Menzel <pmenzel@...gen.mpg.de>
> Sent: poniedziałek, 17 lipca 2023 11:24
> To: Drewek, Wojciech <wojciech.drewek@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; jiri@...nulli.us; simon.horman@...igine.com; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; netdev@...r.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Accept LAG netdevs in bridge offloads
> 
> Dear Wojciech,
> 
> 
> Thank you for your patch.
> 
> 
> Am 17.07.23 um 11:18 schrieb Wojciech Drewek:
> > Allow LAG interfaces to be used in bridge offload using
> > netif_is_lag_master. In this case, search for ice netdev in
> > the list of LAG's lower devices.
> 
> Why weren’t these interfaces allowed to be used like that before? It’d
> be great if you added that information.

Both bridge offload[1] and LAG[2] are not accepted yet. Originally this patch was part of the
bridge offload series but during the review [3] it was suggested that it should go with LAG series.
To sum up, it was intended to support those interfaces from the start.

[1] http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=363510
[2] http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=360621
[3] https://lore.kernel.org/netdev/ZH769agjmFeTLkq9@corigine.com/

Regards,
Wojtek

> 
> > Reviewed-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> > Signed-off-by: Wojciech Drewek <wojciech.drewek@...el.com>
> 
> […]
> 
> 
> Kind nregards,
> 
> Paul