netdev - Re: EEH recovery failing on mlx5 card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Mon, 17 Jul 2023 16:10:06 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Ganesh G R <ganeshgr@...ux.ibm.com>, Moshe Shemesh <moshe@...dia.com>
Cc: saeedm@...dia.com, netdev@...r.kernel.org, oohall@...il.com,
	Mahesh Salgaonkar <mahesh@...ux.ibm.com>
Subject: Re: EEH recovery failing on mlx5 card

+ Moshe

On Mon, Jul 17, 2023 at 12:48:37PM +0530, Ganesh G R wrote:
> Hi,
> 
> mlx5 cards are failing to recover from PCI errors, Upon investigation we found that the
> driver is trying to do MMIO in the middle of EEH error handling.
> The following fix in mlx5_pci_err_detected() is fixing the issue, Do you think its the right fix?
> 
> @@ -1847,6 +1847,7 @@ static pci_ers_result_t mlx5_pci_err_detected(struct pci_dev *pdev,
>         mlx5_unload_one(dev, true);
>         mlx5_drain_health_wq(dev);
>         mlx5_pci_disable_device(dev);
> +       cancel_delayed_work_sync(&clock->timer.overflow_work);
>         res = state == pci_channel_io_perm_failure ?
>                 PCI_ERS_RESULT_DISCONNECT : PCI_ERS_RESULT_NEED_RESET;
> 
> Regards
> Ganesh