netdev - Re: [PATCH net-next 3/3] sctp: Set TOS and routing scope independently for fib lookups.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_eJB9omtsR6xBUN04Z0PHOVZ+e4BP3gr+PrTEnNa3FdqQ@mail.gmail.com>
Date: Mon, 17 Jul 2023 12:06:55 -0400
From: Xin Long <lucien.xin@...il.com>
To: Guillaume Nault <gnault@...hat.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org, 
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, linux-sctp@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] sctp: Set TOS and routing scope
 independently for fib lookups.

On Mon, Jul 17, 2023 at 9:53 AM Guillaume Nault <gnault@...hat.com> wrote:
>
> There's no reason for setting the RTO_ONLINK flag in ->flowi4_tos as
> RT_CONN_FLAGS() does. We can easily set ->flowi4_scope properly
> instead. This makes the code more explicit and will allow to convert
> ->flowi4_tos to dscp_t in the future.
>
> Signed-off-by: Guillaume Nault <gnault@...hat.com>
> ---
>  net/sctp/protocol.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
> index 274d07bd774f..33c0895e101c 100644
> --- a/net/sctp/protocol.c
> +++ b/net/sctp/protocol.c
> @@ -435,7 +435,8 @@ static void sctp_v4_get_dst(struct sctp_transport *t, union sctp_addr *saddr,
>         fl4->fl4_dport = daddr->v4.sin_port;
>         fl4->flowi4_proto = IPPROTO_SCTP;
>         if (asoc) {
> -               fl4->flowi4_tos = RT_CONN_FLAGS_TOS(asoc->base.sk, tos);
> +               fl4->flowi4_tos = RT_TOS(tos);
> +               fl4->flowi4_scope = ip_sock_rt_scope(asoc->base.sk);
>                 fl4->flowi4_oif = asoc->base.sk->sk_bound_dev_if;
>                 fl4->fl4_sport = htons(asoc->base.bind_addr.port);
>         }
> --
> 2.39.2
Reviewed-by: Xin Long <lucien.xin@...il.com>