netdev - Re: [PATCH 1/1] drivers:net: fix return value check in mlx5e_ipsec_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 17 Jul 2023 21:48:10 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Yuanjun Gong <ruc_gongyuanjun@....com>, Saeed Mahameed
 <saeedm@...dia.com>, Boris Pismenny <borisp@...dia.com>,
 Leon Romanovsky <leon@...nel.org>, netdev@...r.kernel.org,
 Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH 1/1] drivers:net: fix return value check in
 mlx5e_ipsec_remove_trailer



On 17/07/2023 17:46, Yuanjun Gong wrote:
> mlx5e_ipsec_remove_trailer should return an error code if function
> pskb_trim returns an unexpected value.
> 

It's a fix, please add a Fixes tag.

> Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@....com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c
> index eab5bc718771..8d995e304869 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c
> @@ -58,7 +58,9 @@ static int mlx5e_ipsec_remove_trailer(struct sk_buff *skb, struct xfrm_state *x)
>   
>   	trailer_len = alen + plen + 2;
>   
> -	pskb_trim(skb, skb->len - trailer_len);
> +	ret = pskb_trim(skb, skb->len - trailer_len);
> +	if (unlikely(ret))
> +		return ret;
>   	if (skb->protocol == htons(ETH_P_IP)) {
>   		ipv4hdr->tot_len = htons(ntohs(ipv4hdr->tot_len) - trailer_len);
>   		ip_send_check(ipv4hdr);

Other than that:
Reviewed-by: Tariq Toukan <tariqt@...dia.com>