netdev - [PROBLEM] selftests: net/forwarding/*.sh: 'Command line is not complete. Try option "help"'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <856d454e-f83c-20cf-e166-6dc06cbc1543@alu.unizg.hr>
Date: Mon, 17 Jul 2023 22:51:04 +0200
From: Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
To: netdev@...r.kernel.org
Cc: linux-kselftest@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
 Ido Schimmel <idosch@...dia.com>, Nikolay Aleksandrov <razor@...ckwall.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [PROBLEM] selftests: net/forwarding/*.sh: 'Command line is not
 complete. Try option "help"'

Hi,

There seems to be a problem with net/forwarding line of 6.5-rc2 kselftests,
vanilla Torvalds tree, commit fdf0eaf11452, on Ubuntu 22.04 LTS Jammy Jellyfish.

(Confirmed on Ubuntu 22.10 Kinetic Kudu.)

Tests fail with error message:

Command line is not complete. Try option "help"
Failed to create netif

The script

# tools/testing/seltests/net/forwarding/bridge_igmp.sh

bash `set -x` ends with an error:

++ create_netif_veth
++ local i
++ (( i = 1 ))
++ (( i <= NUM_NETIFS ))
++ local j=2
++ ip link show dev
++ [[ 255 -ne 0 ]]
++ ip link add type veth peer name
Command line is not complete. Try option "help"
++ [[ 255 -ne 0 ]]
++ echo 'Failed to create netif'
Failed to create netif
++ exit 1

The problem seems to be linked with this piece of code of "lib.sh":

create_netif_veth()
{
         local i

         for ((i = 1; i <= NUM_NETIFS; ++i)); do
                 local j=$((i+1))

                 ip link show dev ${NETIFS[p$i]} &> /dev/null
                 if [[ $? -ne 0 ]]; then
                         ip link add ${NETIFS[p$i]} type veth \
                                 peer name ${NETIFS[p$j]}
                         if [[ $? -ne 0 ]]; then
                                 echo "Failed to create netif"
                                 exit 1
                         fi
                 fi
                 i=$j
         done
}

Somehow, ${NETIFS[p$i]} is evaluated to an empty string?

However, I can't seem to see what is the expected result.

The problem was confirmed in the backlogs of 6.5-rc1 and 6.4 kselftests.

It is possible that I'm doing something terribly wrong, but it is basically
the default kselftest suite on a rather minimal Ubuntu.

Please find attached the bash output from `set -x`.

Version of iproute2 is:
ii  iproute2       5.15.0-1ubuntu2 amd64        networking and traffic control tools

Hope this helps.

Best regards,
Mirsad Todorovac
View attachment "6.5-rc2-net-forwarding.out" of type "text/plain" (2676 bytes)

Download attachment "config-6.5.0-rc2-debug-gfdf0eaf11452.xz" of type "application/x-xz" (57628 bytes)