netdev - RE: [PATCH] net: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 17 Jul 2023 01:47:00 +0000
From: Wei Fang <wei.fang@....com>
To: Rob Herring <robh@...nel.org>, Dario Binacchi
	<dario.binacchi@...rulasolutions.com>, Wolfgang Grandegger
	<wg@...ndegger.com>, Marc Kleine-Budde <mkl@...gutronix.de>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Chandrasekar
 Ramakrishnan <rcsekar@...sung.com>, Chen-Yu Tsai <wens@...e.org>, Jernej
 Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>,
	Florian Fainelli <florian.fainelli@...adcom.com>, Andrew Lunn
	<andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>, Kurt Kanzenbach
	<kurt@...utronix.de>, Woojung Huh <woojung.huh@...rochip.com>,
	"UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
	Arınç ÜNAL <arinc.unal@...nc9.com>, Daniel Golle
	<daniel@...rotopia.org>, Landen Chao <Landen.Chao@...iatek.com>, DENG
 Qingfang <dqfext@...il.com>, Sean Wang <sean.wang@...iatek.com>, Matthias
 Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, Claudiu Manoil
	<claudiu.manoil@....com>, Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Linus Walleij <linus.walleij@...aro.org>, Alvin Šipraga
	<alsi@...g-olufsen.dk>, George McCollister <george.mccollister@...il.com>,
	Andreas Larsson <andreas@...sler.com>, Iyappan Subramanian
	<iyappan@...amperecomputing.com>, Keyur Chudgar
	<keyur@...amperecomputing.com>, Chris Snook <chris.snook@...il.com>, Nicolas
 Ferre <nicolas.ferre@...rochip.com>, Claudiu Beznea
	<claudiu.beznea@...rochip.com>, Madalin Bucur <madalin.bucur@....com>,
	Shenwei Wang <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>,
	dl-linux-imx <linux-imx@....com>, Sean Anderson <sean.anderson@...o.com>,
	Pantelis Antoniou <pantelis.antoniou@...il.com>, Leo Li <leoyang.li@....com>,
	Yisen Zhuang <yisen.zhuang@...wei.com>, Salil Mehta <salil.mehta@...wei.com>,
	Douglas Miller <dougmill@...ux.ibm.com>, Marcin Wojtas <mw@...ihalf.com>,
	Russell King <linux@...linux.org.uk>, Tara s Chornyi
	<taras.chornyi@...ision.eu>, Mirko Lindner <mlindner@...vell.com>, Stephen
 Hemminger <stephen@...workplumber.org>, Felix Fietkau <nbd@....name>, John
 Crispin <john@...ozen.org>, Mark Lee <Mark-MC.Lee@...iatek.com>, Lorenzo
 Bianconi <lorenzo@...nel.org>, Horatiu Vultur <horatiu.vultur@...rochip.com>,
	Timur Tabi <timur@...nel.org>, Sergey Shtylyov <s.shtylyov@....ru>, Steve
 Glendinning <steve.glendinning@...well.net>, Kunihiko Hayashi
	<hayashi.kunihiko@...ionext.com>, Giuseppe Cavallaro
	<peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>, Maxime Coquelin
	<mcoquelin.stm32@...il.com>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
	<s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, Neil Armstrong
	<neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>, Jerome
 Brunet <jbrunet@...libre.com>, Martin Blumenstingl
	<martin.blumenstingl@...glemail.com>, Vinod Ko ul <vkoul@...nel.org>, Bhupesh
 Sharma <bhupesh.sharma@...aro.org>, Emil Renner Berthing <kernel@...il.dk>,
	Samin Guo <samin.guo@...rfivetech.com>, Thierry Reding
	<thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, Nobuhiro
 Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>, Grygorii Strashko
	<grygorii.strashko@...com>, Kevin Brace <kevinbrace@...cecomputerlab.com>,
	Francois Romieu <romieu@...zoreil.com>, Michal Simek <michal.simek@....com>,
	Radhey Shyam Pandey <radhey.shyam.pandey@....com>, Alexander Aring
	<alex.aring@...il.com>, Stefan Schmidt <stefan@...enfreihafen.org>, Miquel
 Raynal <miquel.raynal@...tlin.com>, Alex Elder <elder@...nel.org>,
	Clément Léger <clement.leger@...tlin.com>, Heiner Kallweit
	<hkallweit1@...il.com>, SkyLake Huang <SkyLake.Huang@...iatek.com>, Kalle
 Valo <kvalo@...nel.org>, Loic Poulain <loic.poulain@...aro.org>, Ryder Lee
	<ryder.lee@...iatek.com>, Shayne Chen <shayne.chen@...iatek.com>,
	Jérôme Pouille r <jerome.pouiller@...abs.com>, Richard
 Cochran <richardcochran@...il.com>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-sunxi@...ts.linux.dev"
	<linux-sunxi@...ts.linux.dev>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linuxppc-dev@...ts.ozlabs.org"
	<linuxppc-dev@...ts.ozlabs.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>,
	"linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-amlogic@...ts.infradead.org" <linux-amlogic@...ts.infradead.org>,
	"linux-oxnas@...ups.io" <linux-oxnas@...ups.io>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-wpan@...r.kernel.org" <linux-wpan@...r.kernel.org>,
	"ath10k@...ts.infradead.org" <ath10k@...ts.infradead.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"ath11k@...ts.infradead.org" <ath11k@...ts.infradead.org>,
	"wcn36xx@...ts.infradead.org" <wcn36xx@...ts.infradead.org>
Subject: RE: [PATCH] net: Explicitly include correct DT includes

> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: 2023年7月15日 1:48
> To: Dario Binacchi <dario.binacchi@...rulasolutions.com>; Wolfgang
> Grandegger <wg@...ndegger.com>; Marc Kleine-Budde
> <mkl@...gutronix.de>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; Chandrasekar Ramakrishnan
> <rcsekar@...sung.com>; Chen-Yu Tsai <wens@...e.org>; Jernej Skrabec
> <jernej.skrabec@...il.com>; Samuel Holland <samuel@...lland.org>; Florian
> Fainelli <florian.fainelli@...adcom.com>; Andrew Lunn <andrew@...n.ch>;
> Vladimir Oltean <olteanv@...il.com>; Kurt Kanzenbach <kurt@...utronix.de>;
> Woojung Huh <woojung.huh@...rochip.com>;
> UNGLinuxDriver@...rochip.com; Arınç ÜNAL <arinc.unal@...nc9.com>;
> Daniel Golle <daniel@...rotopia.org>; Landen Chao
> <Landen.Chao@...iatek.com>; DENG Qingfang <dqfext@...il.com>; Sean
> Wang <sean.wang@...iatek.com>; Matthias Brugger
> <matthias.bgg@...il.com>; AngeloGioacchino Del Regno
> <angelogioacchino.delregno@...labora.com>; Claudiu Manoil
> <claudiu.manoil@....com>; Alexandre Belloni
> <alexandre.belloni@...tlin.com>; Linus Walleij <linus.walleij@...aro.org>;
> Alvin Šipraga <alsi@...g-olufsen.dk>; George McCollister
> <george.mccollister@...il.com>; Andreas Larsson <andreas@...sler.com>;
> Iyappan Subramanian <iyappan@...amperecomputing.com>; Keyur Chudgar
> <keyur@...amperecomputing.com>; Chris Snook <chris.snook@...il.com>;
> Nicolas Ferre <nicolas.ferre@...rochip.com>; Claudiu Beznea
> <claudiu.beznea@...rochip.com>; Madalin Bucur <madalin.bucur@....com>;
> Wei Fang <wei.fang@....com>; Shenwei Wang <shenwei.wang@....com>;
> Clark Wang <xiaoning.wang@....com>; dl-linux-imx <linux-imx@....com>;
> Sean Anderson <sean.anderson@...o.com>; Pantelis Antoniou
> <pantelis.antoniou@...il.com>; Leo Li <leoyang.li@....com>; Yisen Zhuang
> <yisen.zhuang@...wei.com>; Salil Mehta <salil.mehta@...wei.com>;
> Douglas Miller <dougmill@...ux.ibm.com>; Marcin Wojtas
> <mw@...ihalf.com>; Russell King <linux@...linux.org.uk>; Tara s Chornyi
> <taras.chornyi@...ision.eu>; Mirko Lindner <mlindner@...vell.com>;
> Stephen Hemminger <stephen@...workplumber.org>; Felix Fietkau
> <nbd@....name>; John Crispin <john@...ozen.org>; Mark Lee
> <Mark-MC.Lee@...iatek.com>; Lorenzo Bianconi <lorenzo@...nel.org>;
> Horatiu Vultur <horatiu.vultur@...rochip.com>; Timur Tabi
> <timur@...nel.org>; Sergey Shtylyov <s.shtylyov@....ru>; Steve Glendinning
> <steve.glendinning@...well.net>; Kunihiko Hayashi
> <hayashi.kunihiko@...ionext.com>; Giuseppe Cavallaro
> <peppe.cavallaro@...com>; Alexandre Torgue <alexandre.torgue@...s.st.com>;
> Jose Abreu <joabreu@...opsys.com>; Maxime Coquelin
> <mcoquelin.stm32@...il.com>; Shawn Guo <shawnguo@...nel.org>; Sascha
> Hauer <s.hauer@...gutronix.de>; Pengutronix Kernel Team
> <kernel@...gutronix.de>; Fabio Estevam <festevam@...il.com>; Neil
> Armstrong <neil.armstrong@...aro.org>; Kevin Hilman
> <khilman@...libre.com>; Jerome Brunet <jbrunet@...libre.com>; Martin
> Blumenstingl <martin.blumenstingl@...glemail.com>; Vinod Ko ul
> <vkoul@...nel.org>; Bhupesh Sharma <bhupesh.sharma@...aro.org>; Emil
> Renner Berthing <kernel@...il.dk>; Samin Guo
> <samin.guo@...rfivetech.com>; Thierry Reding <thierry.reding@...il.com>;
> Jonathan Hunter <jonathanh@...dia.com>; Nobuhiro Iwamatsu
> <nobuhiro1.iwamatsu@...hiba.co.jp>; Grygorii Strashko
> <grygorii.strashko@...com>; Kevin Brace
> <kevinbrace@...cecomputerlab.com>; Francois Romieu
> <romieu@...zoreil.com>; Michal Simek <michal.simek@....com>; Radhey
> Shyam Pandey <radhey.shyam.pandey@....com>; Alexander Aring
> <alex.aring@...il.com>; Stefan Schmidt <stefan@...enfreihafen.org>;
> Miquel Raynal <miquel.raynal@...tlin.com>; Alex Elder <elder@...nel.org>;
> Clément Léger <clement.leger@...tlin.com>; Heiner Kallweit
> <hkallweit1@...il.com>; SkyLake Huang <SkyLake.Huang@...iatek.com>;
> Kalle Valo <kvalo@...nel.org>; Loic Poulain <loic.poulain@...aro.org>; Ryder
> Lee <ryder.lee@...iatek.com>; Shayne Chen <shayne.chen@...iatek.com>;
> Jérôme Pouille r <jerome.pouiller@...abs.com>; Richard Cochran
> <richardcochran@...il.com>
> Cc: devicetree@...r.kernel.org; linux-can@...r.kernel.org;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-sunxi@...ts.linux.dev;
> linux-mediatek@...ts.infradead.org; linuxppc-dev@...ts.ozlabs.org;
> linux-renesas-soc@...r.kernel.org;
> linux-stm32@...md-mailman.stormreply.com;
> linux-amlogic@...ts.infradead.org; linux-oxnas@...ups.io;
> linux-tegra@...r.kernel.org; linux-omap@...r.kernel.org;
> linux-wpan@...r.kernel.org; ath10k@...ts.infradead.org;
> linux-wireless@...r.kernel.org; ath11k@...ts.infradead.org;
> wcn36xx@...ts.infradead.org
> Subject: [PATCH] net: Explicitly include correct DT includes
> 
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h and of.h.
> As a result, there's a pretty much random mix of those include files used
> throughout the tree. In order to detangle these headers and replace the
> implicit includes with struct declarations, users need to explicitly include the
> correct includes.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index ab86bb8562ef..9428a06b6a87 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -30,7 +30,6 @@
>  #include <linux/phy.h>
>  #include <linux/fec.h>
>  #include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/of_gpio.h>
>  #include <linux/of_net.h>
> 
Thanks!
Reviewed-by: Wei Fang <wei.fang@....com>