netdev - Re: [PATCH net-next v4] net: txgbe: change LAN reset mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 17 Jul 2023 08:51:55 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, simon.horman@...igine.com,
	mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next v4] net: txgbe: change LAN reset mode

On Mon, Jul 17, 2023 at 10:13:33AM +0800, Jiawen Wu wrote:
> The old way to do LAN reset is sending reset command to firmware. Once
> firmware performs reset, it reconfigures what it needs.
> 
> In the new firmware versions, veto bit is introduced for NCSI/LLDP to
> block PHY domain in LAN reset. At this point, writing register of LAN
> reset directly makes the same effect as the old way. And it does not
> reset MNG domain, so that veto bit does not change.
> 
> Since veto bit was never used, the old firmware is compatible with the
> driver before and after this change. The new firmware needs to use with
> the driver after this change if it wants to implement the new feature,
> otherwise it is the same as the old firmware.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>
> ---
> v3 -> v4:
> - detail commit log
> - drop fixes tag
> v2 -> v3:
> - post to net-next
> v1 -> v2:
> - detail commit log
> ---
>  drivers/net/ethernet/wangxun/libwx/wx_hw.c    | 65 -------------------
>  drivers/net/ethernet/wangxun/libwx/wx_hw.h    |  1 -
>  drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c |  8 +--
>  3 files changed, 4 insertions(+), 70 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>