netdev - Re: [PATCH v4 2/2] net: phy: motorcomm: Add pad drive strength cfg support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3859b0f6-d31f-dbc3-833e-222eb6ca6b8c@starfivetech.com>
Date: Mon, 17 Jul 2023 16:40:04 +0800
From: Guo Samin <samin.guo@...rfivetech.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<netdev@...r.kernel.org>, Peter Geis <pgwipeout@...il.com>, Frank
	<Frank.Sae@...or-comm.com>, "David S . Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>, Conor Dooley
	<conor@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>,
	Yanhong Wang <yanhong.wang@...rfivetech.com>
Subject: Re: [PATCH v4 2/2] net: phy: motorcomm: Add pad drive strength cfg
 support



-------- 原始信息 --------
主题: Re: [PATCH v4 2/2] net: phy: motorcomm: Add pad drive strength cfg support
From: Andrew Lunn <andrew@...n.ch>
收件人: Samin Guo <samin.guo@...rfivetech.com>
日期: 2023/7/15

>> +static u32 yt8531_get_ds_map(struct phy_device *phydev, u32 cur)
>> +{
>> +	u32 vol;
>> +	int i;
>> +
>> +	vol = yt8531_get_ldo_vol(phydev);
>> +	for (i = 0; i < ARRAY_SIZE(yt8531_ldo_vol); i++) {
>> +		if (yt8531_ldo_vol[i].vol == vol && yt8531_ldo_vol[i].cur == cur)
>> +			return yt8531_ldo_vol[i].ds;
>> +	}
>> +
>> +	phydev_warn(phydev,
>> +		    "No matching current value was found %d, Use default value.\n", cur);
>> +
>> +	return YT8531_RGMII_RX_DS_DEFAULT;
> 
> If there is a value in DT and it is invalid, return -EINVAL and fail
> the probe. Only use the default if there is no value in DT.
> 
>     Andrew

Will be fixed in the next version.

Thanks for taking the time to review the code.

Best regards,
Samin