netdev - Re: [PATCH v1 net 2/4] llc: Check netns in llc_estab_match() and llc_listener

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bff83026bba89cde7c8de594f459cde612937b3.camel@redhat.com>
Date: Tue, 18 Jul 2023 12:38:41 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>, "David S. Miller"
	 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	 <kuba@...nel.org>, Roopa Prabhu <roopa@...dia.com>, Nikolay Aleksandrov
	 <razor@...ckwall.org>
Cc: "Eric W. Biederman" <ebiederm@...ssion.com>, Harry Coin
	 <hcoin@...etfountain.com>, Kuniyuki Iwashima <kuni1840@...il.com>, 
	netdev@...r.kernel.org
Subject: Re: [PATCH v1 net 2/4] llc: Check netns in llc_estab_match() and
 llc_listener_match().

On Fri, 2023-07-14 at 19:13 -0700, Kuniyuki Iwashima wrote:
> @@ -476,7 +478,8 @@ static inline bool llc_estab_match(const struct llc_sap *sap,
>   */
>  static struct sock *__llc_lookup_established(struct llc_sap *sap,
>  					     struct llc_addr *daddr,
> -					     struct llc_addr *laddr)
> +					     struct llc_addr *laddr,
> +					     const struct net *net)

You should add 'net' to the doxygen documentation.

>  {
>  	struct sock *rc;
>  	struct hlist_nulls_node *node;

[...]

> @@ -581,24 +588,26 @@ static struct sock *__llc_lookup_listener(struct llc_sap *sap,
>   *	Caller has to make sure local_bh is disabled.
>   */
>  static struct sock *llc_lookup_listener(struct llc_sap *sap,
> -					struct llc_addr *laddr)
> +					struct llc_addr *laddr,
> +					const struct net *net)

Same here.

Thanks!

Paolo