netdev - Re: [PATCH] net: delete "<< 1U" cargo-culting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jul 2023 12:47:50 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Alexey Dobriyan <adobriyan@...il.com>, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] net: delete "<< 1U" cargo-culting

On Sat, 2023-07-15 at 13:19 +0300, Alexey Dobriyan wrote:
> 6.5.7 §3 "Bitwise shift operators" clearly states that
> 
>         The type of the result is that of the promoted left operand
> 
> All those integer constant suffixes in the right operand are pointless,
> delete them.

Indeed. Still this patch is quite invasive and the net benefit looks
quite marginal - if any at all.

Older compiler could adhere to the standard less strictly or macro
expansion - when the left '<<' operand is a macro argument - could be
tricky.

I think we are better of not applying this.

Cheers,

Paolo