netdev - Re: [PATCH net-next v3 5/5] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2110 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <501615b6-a345-4ecd-9773-1e8d3cb4dfb2@lunn.ch>
Date: Tue, 18 Jul 2023 15:00:51 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Stefan Eichenberger <eichest@...il.com>
Cc: netdev@...r.kernel.org, hkallweit1@...il.com, linux@...linux.org.uk,
	francesco.dolcini@...adex.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next v3 5/5] net: phy: marvell-88q2xxx: add driver
 for the Marvell 88Q2110 PHY

On Tue, Jul 18, 2023 at 09:16:32AM +0200, Stefan Eichenberger wrote:
> Hi Andrew,
> 
> On Mon, Jul 17, 2023 at 11:54:39PM +0200, Andrew Lunn wrote:
> > > +#define MARVELL_PHY_ID_88Q2110	0x002b0981
> > 
> > > +
> > > +static struct phy_driver mv88q2xxx_driver[] = {
> > > +	{
> > > +		.phy_id			= MARVELL_PHY_ID_88Q2110,
> > > +		.phy_id_mask		= MARVELL_PHY_ID_MASK,
> > 
> > Probably not an issue...
> > 
> > The ID you have above is for revision 1 of the PHY. But the mask will
> > cause the revision to be ignored. Do you want to ignore the revision?
> > Are there different errata for revision 0 and 1?
> 
> A0 to A2 (Rev 1-3) are the same software wise for the current scenarios.
> Z0 (Rev 0) might behave slightly different in the reset scenario but
> most likely it works as well. Unfortunately, I could not test it because
> I don't have such a device.

Thanks.

Please consider Marek comment, but:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew