netdev - Re: [PATCH] USB: zaurus: 3 broken Zaurus devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 18 Jul 2023 15:28:20 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Ross Maynard <bids.7405@...pond.com>
Cc: linux-usb@...r.kernel.org, netdev@...r.kernel.org, davem@...emloft.net,
	kuba@...nel.org, Oliver Neukum <oneukum@...e.com>
Subject: Re: [PATCH] USB: zaurus: 3 broken Zaurus devices

On Tue, Jul 18, 2023 at 10:16:55AM +1000, Ross Maynard wrote:
> Hi Greg,
> 
> This is related to Oliver Neukum's patch
> 6605cc67ca18b9d583eb96e18a20f5f4e726103c (USB: zaurus: support another
> broken Zaurus) which you committed in 2022 to fix broken support for the
> Zaurus SL-6000.
> 
> Prior to that I had been able to track down the original offending patch
> using git bisect as you had suggested to me:
> 16adf5d07987d93675945f3cecf0e33706566005 (usbnet: Remove over-broad module
> alias from zaurus).
> 
> It turns out that the offending patch also broke support for 3 other Zaurus
> models: A300, C700 and B500/SL-5600. My patch adds the 3 device IDs to the
> driver in the same way Oliver added the SL-6000 ID in his patch.
> 
> Could you please review the attached patch? I tested it on all 3 devices and
> it fixed the problem. For your reference, the associated bug URL is
> https://bugzilla.kernel.org/show_bug.cgi?id=217632.
> 
> Thank you.
> 
> Regards,
> 
> Ross
> 

> Signed-off-by: Ross Maynard <bids.7405@...pond.com>
> Reported-by: Ross Maynard <bids.7405@...pond.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217632
> ---
>  drivers/net/usb/cdc_ether.c | 21 +++++++++++++++++++++
>  drivers/net/usb/zaurus.c    | 21 +++++++++++++++++++++
>  2 files changed, 42 insertions(+)
> 
> --- a/drivers/net/usb/cdc_ether.c
> +++ b/drivers/net/usb/cdc_ether.c
> @@ -616,6 +616,13 @@ static const struct usb_device_id	products[] = {
>  }, {
>  	.match_flags	=   USB_DEVICE_ID_MATCH_INT_INFO
>  			  | USB_DEVICE_ID_MATCH_DEVICE,
> +	.idVendor		= 0x04DD,
> +	.idProduct		= 0x8005,   /* A-300 */
> +	ZAURUS_FAKE_INTERFACE,
> +	.driver_info        = 0,
> +}, {
> +	.match_flags    =   USB_DEVICE_ID_MATCH_INT_INFO
> +			  | USB_DEVICE_ID_MATCH_DEVICE,
>  	.idVendor		= 0x04DD,
>  	.idProduct		= 0x8006,	/* B-500/SL-5600 */
>  	ZAURUS_MASTER_INTERFACE,
> @@ -623,12 +630,26 @@ static const struct usb_device_id	products[] = {
>  }, {
>  	.match_flags    =   USB_DEVICE_ID_MATCH_INT_INFO
>  			  | USB_DEVICE_ID_MATCH_DEVICE,
> +	.idVendor		= 0x04DD,
> +	.idProduct		= 0x8006,   /* B-500/SL-5600 */
> +	ZAURUS_FAKE_INTERFACE,
> +	.driver_info        = 0,
> +}, {
> +	.match_flags    =   USB_DEVICE_ID_MATCH_INT_INFO
> +			  | USB_DEVICE_ID_MATCH_DEVICE,
>  	.idVendor		= 0x04DD,
>  	.idProduct		= 0x8007,	/* C-700 */
>  	ZAURUS_MASTER_INTERFACE,
>  	.driver_info		= 0,
>  }, {
>  	.match_flags    =   USB_DEVICE_ID_MATCH_INT_INFO
> +			  | USB_DEVICE_ID_MATCH_DEVICE,
> +	.idVendor		= 0x04DD,
> +	.idProduct		= 0x8007,   /* C-700 */
> +	ZAURUS_FAKE_INTERFACE,
> +	.driver_info        = 0,
> +}, {
> +	.match_flags    =   USB_DEVICE_ID_MATCH_INT_INFO
>  		 | USB_DEVICE_ID_MATCH_DEVICE,
>  	.idVendor               = 0x04DD,
>  	.idProduct              = 0x9031,	/* C-750 C-760 */
> --- a/drivers/net/usb/zaurus.c
> +++ b/drivers/net/usb/zaurus.c
> @@ -289,9 +289,23 @@ static const struct usb_device_id	products [] = {
>  	.match_flags	=   USB_DEVICE_ID_MATCH_INT_INFO
>  			  | USB_DEVICE_ID_MATCH_DEVICE,
>  	.idVendor		= 0x04DD,
> +	.idProduct		= 0x8005,	/* A-300 */
> +	ZAURUS_FAKE_INTERFACE,
> +	.driver_info = (unsigned long)&bogus_mdlm_info,
> +}, {
> +	.match_flags    =   USB_DEVICE_ID_MATCH_INT_INFO
> +			  | USB_DEVICE_ID_MATCH_DEVICE,
> +	.idVendor		= 0x04DD,
>  	.idProduct		= 0x8006,	/* B-500/SL-5600 */
>  	ZAURUS_MASTER_INTERFACE,
>  	.driver_info = ZAURUS_PXA_INFO,
> +}, {
> +	.match_flags    =   USB_DEVICE_ID_MATCH_INT_INFO
> +			  | USB_DEVICE_ID_MATCH_DEVICE,
> +	.idVendor		= 0x04DD,
> +	.idProduct		= 0x8006,	/* B-500/SL-5600 */
> +	ZAURUS_FAKE_INTERFACE,
> +	.driver_info = (unsigned long)&bogus_mdlm_info,
>  }, {
>  	.match_flags    =   USB_DEVICE_ID_MATCH_INT_INFO
>  	          | USB_DEVICE_ID_MATCH_DEVICE,
> @@ -301,6 +315,13 @@ static const struct usb_device_id	products [] = {
>  	.driver_info = ZAURUS_PXA_INFO,
>  }, {
>  	.match_flags    =   USB_DEVICE_ID_MATCH_INT_INFO
> +			  | USB_DEVICE_ID_MATCH_DEVICE,
> +	.idVendor		= 0x04DD,
> +	.idProduct		= 0x8007,	/* C-700 */
> +	ZAURUS_FAKE_INTERFACE,
> +	.driver_info = (unsigned long)&bogus_mdlm_info,
> +}, {
> +	.match_flags    =   USB_DEVICE_ID_MATCH_INT_INFO
>  		 | USB_DEVICE_ID_MATCH_DEVICE,
>  	.idVendor               = 0x04DD,
>  	.idProduct              = 0x9031,	/* C-750 C-760 */
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot