netdev - Re: [PATCH 1/1] net:openvswitch: check return value of pskb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202307182349.2ivzwQk9-lkp@intel.com>
Date: Tue, 18 Jul 2023 23:28:52 +0800
From: kernel test robot <lkp@...el.com>
To: Yuanjun Gong <ruc_gongyuanjun@....com>,
	Pravin B Shelar <pshelar@....org>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH 1/1] net:openvswitch: check return value of pskb_trim()

Hi Yuanjun,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.5-rc2 next-20230718]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yuanjun-Gong/net-openvswitch-check-return-value-of-pskb_trim/20230718-190417
base:   linus/master
patch link:    https://lore.kernel.org/r/20230717145024.27274-1-ruc_gongyuanjun%40163.com
patch subject: [PATCH 1/1] net:openvswitch: check return value of pskb_trim()
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230718/202307182349.2ivzwQk9-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230718/202307182349.2ivzwQk9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307182349.2ivzwQk9-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/openvswitch/actions.c: In function 'do_output':
>> net/openvswitch/actions.c:922:28: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
     922 |                         if (skb->len - cutlen > ovs_mac_header_len(key))
         |                            ^


vim +/else +922 net/openvswitch/actions.c

7f8a436eaa2c3d Joe Stringer      2015-08-26  911  
7f8a436eaa2c3d Joe Stringer      2015-08-26  912  static void do_output(struct datapath *dp, struct sk_buff *skb, int out_port,
7f8a436eaa2c3d Joe Stringer      2015-08-26  913  		      struct sw_flow_key *key)
ccb1352e76cff0 Jesse Gross       2011-10-25  914  {
738967b8bf57e5 Andy Zhou         2014-09-08  915  	struct vport *vport = ovs_vport_rcu(dp, out_port);
ccb1352e76cff0 Jesse Gross       2011-10-25  916  
066b86787fa3d9 Felix Huettner    2023-04-05  917  	if (likely(vport && netif_carrier_ok(vport->dev))) {
7f8a436eaa2c3d Joe Stringer      2015-08-26  918  		u16 mru = OVS_CB(skb)->mru;
f2a4d086ed4c58 William Tu        2016-06-10  919  		u32 cutlen = OVS_CB(skb)->cutlen;
f2a4d086ed4c58 William Tu        2016-06-10  920  
f2a4d086ed4c58 William Tu        2016-06-10  921  		if (unlikely(cutlen > 0)) {
e2d9d8358cb961 Jiri Benc         2016-11-10 @922  			if (skb->len - cutlen > ovs_mac_header_len(key))
ec8358d8ed17bf Yuanjun Gong      2023-07-17  923  				if (pskb_trim(skb, skb->len - cutlen))
ec8358d8ed17bf Yuanjun Gong      2023-07-17  924  					kfree_skb(skb);
f2a4d086ed4c58 William Tu        2016-06-10  925  			else
ec8358d8ed17bf Yuanjun Gong      2023-07-17  926  				if (pskb_trim(skb, ovs_mac_header_len(key)))
ec8358d8ed17bf Yuanjun Gong      2023-07-17  927  					kfree_skb(skb);
f2a4d086ed4c58 William Tu        2016-06-10  928  		}
7f8a436eaa2c3d Joe Stringer      2015-08-26  929  
738314a084aae5 Jiri Benc         2016-11-10  930  		if (likely(!mru ||
738314a084aae5 Jiri Benc         2016-11-10  931  		           (skb->len <= mru + vport->dev->hard_header_len))) {
e2d9d8358cb961 Jiri Benc         2016-11-10  932  			ovs_vport_send(vport, skb, ovs_key_mac_proto(key));
7f8a436eaa2c3d Joe Stringer      2015-08-26  933  		} else if (mru <= vport->dev->mtu) {
c559cd3ad32ba7 Eric W. Biederman 2015-09-14  934  			struct net *net = read_pnet(&dp->net);
7f8a436eaa2c3d Joe Stringer      2015-08-26  935  
e2d9d8358cb961 Jiri Benc         2016-11-10  936  			ovs_fragment(net, vport, skb, mru, key);
7f8a436eaa2c3d Joe Stringer      2015-08-26  937  		} else {
7f8a436eaa2c3d Joe Stringer      2015-08-26  938  			kfree_skb(skb);
7f8a436eaa2c3d Joe Stringer      2015-08-26  939  		}
7f8a436eaa2c3d Joe Stringer      2015-08-26  940  	} else {
738967b8bf57e5 Andy Zhou         2014-09-08  941  		kfree_skb(skb);
ccb1352e76cff0 Jesse Gross       2011-10-25  942  	}
7f8a436eaa2c3d Joe Stringer      2015-08-26  943  }
ccb1352e76cff0 Jesse Gross       2011-10-25  944  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki