netdev - Re: [PATCH net-next 7/8] can: kvaser_pciefd: Move hardware specific constants and functions into a driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230719-flint-saloon-a64345c0243c-mkl@pengutronix.de>
Date: Wed, 19 Jul 2023 09:25:17 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, linux-can@...r.kernel.org,
	kernel@...gutronix.de, Jimmy Assarsson <extja@...ser.com>,
	Martin Jocic <majoc@...ser.com>
Subject: Re: [PATCH net-next 7/8] can: kvaser_pciefd: Move hardware specific
 constants and functions into a driver_data struct

On 19.07.2023 08:53:04, Marc Kleine-Budde wrote:
> On 18.07.2023 18:33:15, Jakub Kicinski wrote:
> > On Mon, 17 Jul 2023 20:22:28 +0200 Marc Kleine-Budde wrote:
> > > +const struct kvaser_pciefd_address_offset kvaser_pciefd_altera_address_offset = {
> > 
> > > +const struct kvaser_pciefd_irq_mask kvaser_pciefd_altera_irq_mask = {
> > 
> > > +const struct kvaser_pciefd_dev_ops kvaser_pciefd_altera_dev_ops = {
> > 
> > > +const struct kvaser_pciefd_driver_data kvaser_pciefd_altera_driver_data = {
> > 
> > sparse points out the structs in this and subsequent patch should
> > be static. Would you be able to queue a quick fix on top and resend,
> > or should we pull as is?
> 
> Sorry, I'll post an updated pull request.

https://lore.kernel.org/all/20230719072348.525039-1-mkl@pengutronix.de

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)